So the original developer writes crap code (whether as a result of burn-out and exhaustion, or just that is the level of talent they have), and the fault for that code almost making it into the kernel is a lack of review, without any responsibility on the coder? And then, once the issue has been identified and the process criticised, the people who gave that person the ability to post such crap code are more focussed on being upset about the criticism than they are about addressing the code and quality issue
Unless you have proper process in place to ensure quality of code, your entire codebase becomes as bad as your worst developer (one buffer overflow in the kernel and the attacker owns it, no matter how many other parts have been well written). Publicly shaming the developer is not going to accomplish much, perhaps detract them from participating in the project, which might sounds like a good thing, but there will be more and more even worse developers, not yet publicly shamed, who will take their place.
I am a believer in direct and honest review feedback, and prefer to work with people who don't take code reviews personally, but public shaming as a goal accomplishes nothing productive.
"Not my monkeys, not my circus" (Score:5, Interesting)
So the original developer writes crap code (whether as a result of burn-out and exhaustion, or just that is the level of talent they have), and the fault for that code almost making it into the kernel is a lack of review, without any responsibility on the coder?
And then, once the issue has been identified and the process criticised, the people who gave that person the ability to post such crap code are more focussed on being upset about the criticism than they are about addressing the code and quality issue
Re:"Not my monkeys, not my circus" (Score:2)
Unless you have proper process in place to ensure quality of code, your entire codebase becomes as bad as your worst developer (one buffer overflow in the kernel and the attacker owns it, no matter how many other parts have been well written). Publicly shaming the developer is not going to accomplish much, perhaps detract them from participating in the project, which might sounds like a good thing, but there will be more and more even worse developers, not yet publicly shamed, who will take their place.
I am a believer in direct and honest review feedback, and prefer to work with people who don't take code reviews personally, but public shaming as a goal accomplishes nothing productive.